AbsaOSS / AbsaOSS/enceladus

Use slf4j instead of log4j everywhere in the project

Abierto
#802 0 comentarios 0 reacciones 0 asignados Ver en GitHub
feature priority: low refactoring
Lenguaje dominante
Scala
Estrellas
33
Forks
16
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

## Background
Reported by @GeorgiChochov.

Slf4j is an abstraction layer for logging and exact implementation to use is determined at deployment time. Currently, Spark is our root project dependency and it uses log4j implementation. Rather than depending on a concrete logging backend, it is a good practice to make modules depend on interfaces provided by slf4j. In our case, the logging backend is provided by Spark. So another reason to use slf4j.

## Feature
Use slf4j instead of log4j everywhere in the project. Especially everywhere we have Spark dependency.

## Proposed Solution [Optional]
Basically,

replace

```scala
import org.apache.log4j.LogManager

private val log = LogManager.getLogger(this.getClass)
```

with

```scala
import org.slf4j.{Logger, LoggerFactory}

private val log: Logger = LoggerFactory.getLogger(this.getClass)
```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.