AbsaOSS / AbsaOSS/cobrix

Unifying readers

Abierto
#280 7 comentarios 0 reacciones 0 asignados Ver en GitHub
question
Lenguaje dominante
Scala
Estrellas
170
Forks
96
Merge medio
57 min
PR fusionados (30 d)
2

Descripción

I'm trying to write a JSON reader based on the new split of packages, but am finding that I'm repeating a lot of the code on the Spark side, so I was wondering whether we can come up with a more generic way to deal with creating readers (fixed vs var len) and bring those methods to the Reader trait. I tried doing something along those lines in https://github.com/tr11/cobrix/tree/unify-readers but I'm not sure if that's the best approach.
Ideally, I was looking for a solution that
- creates an iterator of records that is independent of the type of file we have, so all the methods should be defined in trait vs in specialized Var vs Fixed readers
- push all the logic to the reader package, including parameter processing, etc
Any thoughts on this?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.