AbsaOSS / AbsaOSS/cobrix

Unifying readers

Open
#280 7 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
Scala
Stars
170
Forks
96
Avg merge
57m
Merged PRs (30d)
2

Description

I'm trying to write a JSON reader based on the new split of packages, but am finding that I'm repeating a lot of the code on the Spark side, so I was wondering whether we can come up with a more generic way to deal with creating readers (fixed vs var len) and bring those methods to the Reader trait. I tried doing something along those lines in https://github.com/tr11/cobrix/tree/unify-readers but I'm not sure if that's the best approach.
Ideally, I was looking for a solution that
- creates an iterator of records that is independent of the type of file we have, so all the methods should be defined in trait vs in specialized Var vs Fixed readers
- push all the logic to the reader package, including parameter processing, etc
Any thoughts on this?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.