AOSSIE-Org / AOSSIE-Org/Template-Repo

Fix: Hard-coded checklist items in dangerfile.js don't match PR template

未关闭
#112 0 条评论 0 个 reaction 已指派 1 人 已被 @kpj2006 认领 在 GitHub 查看
主要语言
YAML
星标
17
派生
29
平均合并
3 天 13 小时
30 天内合并 PR
6

描述

## Summary

The `requiredChecklistItems` array in `dangerfile.js` contains hard-coded checklist strings that don't match the actual PR template checklist items. This causes compliant PRs to be incorrectly flagged by the Danger CI check.

## Problem

The current strings in `dangerfile.js` are:
- `"My PR addresses a single issue"`
- `"My code follows the project's code style"`
- `"My changes generate no new warnings or errors"`

However, the actual PR template checklist contains different text, causing false negatives.

## Proposed Fix

Update `requiredChecklistItems` to exactly match the PR template text, or implement tolerant/label-based matching (case-insensitive, whitespace-normalized) to avoid future drift.

## References

- PR: https://github.com/AOSSIE-Org/Template-Repo/pull/111
- Review comment: https://github.com/AOSSIE-Org/Template-Repo/pull/111#discussion_r3005886058

Reported by: @kpj2006

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。