AOSSIE-Org / AOSSIE-Org/Template-Repo

Fix: Hard-coded checklist items in dangerfile.js don't match PR template

Abierto
#112 0 comentarios 0 reacciones 1 asignado Reclamado por @kpj2006 Ver en GitHub
Lenguaje dominante
YAML
Estrellas
17
Forks
29
Merge medio
3 d 13 h
PR fusionados (30 d)
6

Descripción

## Summary

The `requiredChecklistItems` array in `dangerfile.js` contains hard-coded checklist strings that don't match the actual PR template checklist items. This causes compliant PRs to be incorrectly flagged by the Danger CI check.

## Problem

The current strings in `dangerfile.js` are:
- `"My PR addresses a single issue"`
- `"My code follows the project's code style"`
- `"My changes generate no new warnings or errors"`

However, the actual PR template checklist contains different text, causing false negatives.

## Proposed Fix

Update `requiredChecklistItems` to exactly match the PR template text, or implement tolerant/label-based matching (case-insensitive, whitespace-normalized) to avoid future drift.

## References

- PR: https://github.com/AOSSIE-Org/Template-Repo/pull/111
- Review comment: https://github.com/AOSSIE-Org/Template-Repo/pull/111#discussion_r3005886058

Reported by: @kpj2006

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.