AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Memories routes define Pydantic response models (Memory, GenerateMemoriesResponse, ...) that are never used; responses are unvalidated and inconsistent with other routers ```

Aberta
#1,348 5 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
Python
Estrelas
283
Forks
679
Merge médio
7d 2h
PRs com merge (30d)
3

Descrição

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

`backend/app/routes/memories.py:39-112` defines `MemoryImage`, `Memory`, `GenerateMemoriesResponse`, `TimelineResponse`, `OnThisDayResponse`, `LocationCluster`, `LocationsResponse` — but none of the endpoints set `response_model=`, and they instead return raw `{"data": {...}, "success": ..., "message": ...}` dicts whose shape doesn't match those models. Result: dead code, no response validation, and an envelope inconsistent with every other router (which uses typed `response_model`s).

**Fix:** either wire the models in via `response_model=` (and align the `{data, success, message}` envelope), or delete the unused models.

### Record

- [x] I agree to follow this project's Code of Conduct

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.