AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Memories routes define Pydantic response models (Memory, GenerateMemoriesResponse, ...) that are never used; responses are unvalidated and inconsistent with other routers ```

Aperta
#1,348 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
283
Fork
679
Merge medio
7g 2h
PR unite (30g)
3

Descrizione

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

`backend/app/routes/memories.py:39-112` defines `MemoryImage`, `Memory`, `GenerateMemoriesResponse`, `TimelineResponse`, `OnThisDayResponse`, `LocationCluster`, `LocationsResponse` — but none of the endpoints set `response_model=`, and they instead return raw `{"data": {...}, "success": ..., "message": ...}` dicts whose shape doesn't match those models. Result: dead code, no response validation, and an envelope inconsistent with every other router (which uses typed `response_model`s).

**Fix:** either wire the models in via `response_model=` (and align the `{data, success, message}` envelope), or delete the unused models.

### Record

- [x] I agree to follow this project's Code of Conduct

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.