AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Memories routes define Pydantic response models (Memory, GenerateMemoriesResponse, ...) that are never used; responses are unvalidated and inconsistent with other routers ```

Abierto
#1,348 5 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
283
Forks
679
Merge medio
7 d 2 h
PR fusionados (30 d)
3

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

`backend/app/routes/memories.py:39-112` defines `MemoryImage`, `Memory`, `GenerateMemoriesResponse`, `TimelineResponse`, `OnThisDayResponse`, `LocationCluster`, `LocationsResponse` — but none of the endpoints set `response_model=`, and they instead return raw `{"data": {...}, "success": ..., "message": ...}` dicts whose shape doesn't match those models. Result: dead code, no response validation, and an envelope inconsistent with every other router (which uses typed `response_model`s).

**Fix:** either wire the models in via `response_model=` (and align the `{data, success, message}` envelope), or delete the unused models.

### Record

- [x] I agree to follow this project's Code of Conduct

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.