AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Production backend/sync sidecars only spawn under the `ci` Cargo feature - misnamed flag is a silent footgun

未关闭
#1,347 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
283
派生
679
平均合并
7 天 2 小时
30 天内合并 PR
3

描述

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

In `frontend/src-tauri/src/main.rs`, the `prod()` function that spawns the bundled Python sidecars (`PictoPy_Server`, `PictoPy_Sync`) is gated behind `#[cfg(feature = "ci")]` (line 105); the `#[cfg(not(feature = "ci"))]` variant (line 186) is a **no-op**. Release builds work today because the workflows pass `--features ci` - but the name implies "continuous integration", so anyone building a release without that flag gets an app that launches and **silently never starts its backend**, with no error.

**Fix:** rename the feature to something descriptive (e.g. `bundled-sidecars`) and/or make a release build without it fail loudly. Feature defined at `frontend/src-tauri/Cargo.toml:44`.

### Record

- [x] I agree to follow this project's Code of Conduct

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。