AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Production backend/sync sidecars only spawn under the `ci` Cargo feature - misnamed flag is a silent footgun

Abierto
#1,347 2 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
283
Forks
679
Merge medio
7 d 2 h
PR fusionados (30 d)
3

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

In `frontend/src-tauri/src/main.rs`, the `prod()` function that spawns the bundled Python sidecars (`PictoPy_Server`, `PictoPy_Sync`) is gated behind `#[cfg(feature = "ci")]` (line 105); the `#[cfg(not(feature = "ci"))]` variant (line 186) is a **no-op**. Release builds work today because the workflows pass `--features ci` - but the name implies "continuous integration", so anyone building a release without that flag gets an app that launches and **silently never starts its backend**, with no error.

**Fix:** rename the feature to something descriptive (e.g. `bundled-sidecars`) and/or make a release build without it fail loudly. Feature defined at `frontend/src-tauri/Cargo.toml:44`.

### Record

- [x] I agree to follow this project's Code of Conduct

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.