AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: [Audit] Backend: Inconsistent password hashing and missing DB rollback logic

未关闭
#1,244 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Python
星标
283
派生
679
平均合并
7 天 2 小时
30 天内合并 PR
3

描述

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

During a preliminary technical audit of the PictoPy backend for GSoC 2026, I identified two logical issues that could affect system stability:

Password Consistency: Empty strings are currently being hashed in some paths instead of being treated as None.

Transaction Integrity: The metadata write flow lacks a rollback() mechanism, which could lead to partial data writes if an execution fails.

I have already researched and prepared a fix for these issues to ensure production-grade reliability.

Note: I previously opened PR #1242 with the fixes. I am opening this issue now to follow the proper contribution workflow as requested by the mentor.

MyPy Scan Before Fixes (54 Errors):

Image

MyPy Scan After Fixes (49 Errors):

Image

### Record

- [x] I agree to follow this project's Code of Conduct

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。