AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: [Audit] Backend: Inconsistent password hashing and missing DB rollback logic

Abierto
#1,244 5 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
283
Forks
679
Merge medio
7 d 2 h
PR fusionados (30 d)
3

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

During a preliminary technical audit of the PictoPy backend for GSoC 2026, I identified two logical issues that could affect system stability:

Password Consistency: Empty strings are currently being hashed in some paths instead of being treated as None.

Transaction Integrity: The metadata write flow lacks a rollback() mechanism, which could lead to partial data writes if an execution fails.

I have already researched and prepared a fix for these issues to ensure production-grade reliability.

Note: I previously opened PR #1242 with the fixes. I am opening this issue now to follow the proper contribution workflow as requested by the mentor.

MyPy Scan Before Fixes (54 Errors):

Image

MyPy Scan After Fixes (49 Errors):

Image

### Record

- [x] I agree to follow this project's Code of Conduct

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.