AOSSIE-Org / AOSSIE-Org/PictoPy
fix: improve SQLite error handling and logging in face_clusters.py
未關閉
- 主要語言
- Python
- 星號
- 283
- 分支
- 679
- 平均合併
- 7 天 2 小時
- 30 天內合併 PR
- 3
描述
`face_clusters.py` has multiple problems:
- `db_delete_all_clusters` uses broad `except Exception` and `print()` instead of logging
- `db_insert_clusters_batch` catches no exceptions at all
- 5 other functions have no exception handling
### Proposed fix
- Replace `except Exception` with `sqlite3.Error` across all functions
- Replace `print()` with `logger.error()`
- Add `sqlite3.Error` handling to unprotected functions
- Add `import logging` and `logger = logging.getLogger(__name__)`
I'd like to fix this.
貢獻指南
評估
這個 Issue 還沒有評估資料。