AOSSIE-Org / AOSSIE-Org/PictoPy

fix: improve SQLite error handling and logging in face_clusters.py

Open
#1,230 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
283
Forks
679
Avg merge
7d 2h
Merged PRs (30d)
3

Description

`face_clusters.py` has multiple problems:

- `db_delete_all_clusters` uses broad `except Exception` and `print()` instead of logging
- `db_insert_clusters_batch` catches no exceptions at all
- 5 other functions have no exception handling

### Proposed fix
- Replace `except Exception` with `sqlite3.Error` across all functions
- Replace `print()` with `logger.error()`
- Add `sqlite3.Error` handling to unprotected functions
- Add `import logging` and `logger = logging.getLogger(__name__)`

I'd like to fix this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.