AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Backend: "Conn is possibly unbound" can break db connections

未關閉
#1,028 4 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
283
分支
679
平均合併
7 天 2 小時
30 天內合併 PR
3

描述

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

There exists at least one execution path where conn might be used before being assigned.
This may break db connections.

Example - face_clusters.py
- Can break functions like db_delete_all_clusters, db_insert_clusters_batch, db_update_cluster
- Definitely causes issue in db_update_cluster, which will be very hard to debug if not fixed now

## Found unbound conns

### face_clusters.py
- Line 61 ,65, 70, 115, 119, 123

### faces.py
- Line 333, 336, 341

### metadata.py
- Line 85, 89, 95

### face_clusters.py
- Line 622, 627, 633

I would like to work on this issue

### Record

- [x] I agree to follow this project's Code of Conduct

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。