AOSSIE-Org / AOSSIE-Org/PictoPy

BUG: Backend: "Conn is possibly unbound" can break db connections

Abierto
#1,028 4 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
283
Forks
679
Merge medio
7 d 2 h
PR fusionados (30 d)
3

Descripción

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

There exists at least one execution path where conn might be used before being assigned.
This may break db connections.

Example - face_clusters.py
- Can break functions like db_delete_all_clusters, db_insert_clusters_batch, db_update_cluster
- Definitely causes issue in db_update_cluster, which will be very hard to debug if not fixed now

## Found unbound conns

### face_clusters.py
- Line 61 ,65, 70, 115, 119, 123

### faces.py
- Line 333, 336, 341

### metadata.py
- Line 85, 89, 95

### face_clusters.py
- Line 622, 627, 633

I would like to work on this issue

### Record

- [x] I agree to follow this project's Code of Conduct

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.