AOSSIE-Org / AOSSIE-Org/NeuroTrack

BUG: Discarded Provider.of call in AuthScreen causes unnecessary widget rebuilds

Aperta
#186 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Dart
Stelle
29
Fork
50
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

## Description
In `auth_screen.dart`, inside the `build()` method, there is a `Provider.of`
call whose return value is immediately discarded:

## Current Behavior
Provider.of(context, listen: true).authNavigationStatus;

This line forces a full widget rebuild every time AuthProvider changes,
even though the value is never used in the UI. This is a silent performance
issue that can cause janky behavior on low-end devices.

## Expected Behavior
Rebuilds should only happen when the value is actually consumed by the UI.
The navigation logic is already handled in `didChangeDependencies`,
making this line redundant.

## Proposed Fix
Remove the redundant line entirely, since `didChangeDependencies` already
reacts to AuthProvider changes for navigation purposes.

## File
lib/presentation/auth/auth_screen.dart — build() method

### Record

- [x] I agree to follow this project's Code of Conduct
- [x] I want to work on this issue

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.