AOSSIE-Org / AOSSIE-Org/NeuroTrack

BUG: Discarded Provider.of call in AuthScreen causes unnecessary widget rebuilds

Offen
#186 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Dart
Sterne
29
Forks
50
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

### Is there an existing issue for this?

- [x] I have searched the existing issues

### What happened?

## Description
In `auth_screen.dart`, inside the `build()` method, there is a `Provider.of`
call whose return value is immediately discarded:

## Current Behavior
Provider.of(context, listen: true).authNavigationStatus;

This line forces a full widget rebuild every time AuthProvider changes,
even though the value is never used in the UI. This is a silent performance
issue that can cause janky behavior on low-end devices.

## Expected Behavior
Rebuilds should only happen when the value is actually consumed by the UI.
The navigation logic is already handled in `didChangeDependencies`,
making this line redundant.

## Proposed Fix
Remove the redundant line entirely, since `didChangeDependencies` already
reacts to AuthProvider changes for navigation purposes.

## File
lib/presentation/auth/auth_screen.dart — build() method

### Record

- [x] I agree to follow this project's Code of Conduct
- [x] I want to work on this issue

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.