ADORSYS-GIS / ADORSYS-GIS/lightbridge-governance

[Ticket]: Split app/governance-ctl/src/sync.rs (1178 LoC)

オープン
#178 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
ticket
主要言語
Rust
スター
1
フォーク
2
平均マージ
14時間 36分
マージ済み PR(30日)
107

説明

### Type

Refactor

### Summary

`app/governance-ctl/src/sync.rs` is 1178 lines. Split it along its real seams to bring every resulting file under 200.

### Intent

It is one of the largest files in the repository and, at this size, is skimmed rather than reviewed.

### Source of truth (links)

- #162 (parent epic), #173 (baseline)

### Acceptance Criteria

1. No resulting file exceeds 200 LoC.
2. **Behaviour is unchanged** — the existing tests pass before and after, unmodified.
3. No test is weakened, deleted or made less specific to accommodate the split.
4. Module boundaries follow a real seam, not an arbitrary line count.
5. Public API unchanged, or the change is called out explicitly.

### Out of Scope

Behaviour changes of any kind. This is a pure refactor.

### Technical Context

The copilot-sync command. Seams: fetch, parse, upsert, manifest bookkeeping.

### Risks

⚠️ A shrinking file that also shrinks its assertions is a regression wearing a refactor's clothes. Reviewers should diff the test count and the assertion count, not just the line count.

### Test Plan

The existing suite, unmodified, before and after. If a test needed changing, say why in the PR — that is the signal worth reviewing.

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Read app/governance-ctl/src/sync.rs and the linked baseline #173; map the fetch, parse, upsert, and manifest-bookkeeping seams, then run the existing suite before changing anything. Split only along those seams while preserving the public API and tests. Done means every resulting file is under 200 LoC, behavior is unchanged, and test and assertion counts are unchanged.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
rust
領域
cli
issue の種類
リファクタリング
難易度
4/5
見積もり時間
3〜5日
活発さ
活発
明瞭さ
おおむね明確
初心者へのやさしさ
57/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。