5zig-reborn / 5zig-reborn/The-5zig-Mod

All Chat Filters Break if a Regex Filter cannot be Read

未关闭
#94 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Suggestion
主要语言
Java
星标
111
派生
12
PR 合并指标
30 天内没有已合并 PR

描述

Submitter: Yoshi
If a chat filter configured to be regex has some sort of problem and cannot be read (e.g. unmatched group parentheses), all other chat filters break completely upon relaunching the game.
This would not be a problem if one were told that the regex filter has some sort of regex problem before creation. However, no indication that something is wrong is visually said.
The only way to know is to look in the minecraft log as the incorrect regex string is created. In the log, this is shown: https://pastebin.com/dUYUu5ty
Upon relaunching the game and having a message be sent in chat, this 5zig/WARN is shown, and no chat filtering is applied at all: https://pastebin.com/jWtDRm6r

Therefore, the simplest solution to this problem is to not allow a regex chat filter be saved/created if there is a regex problem. Additionally, it would be helpful to specify the problem upon attempting to create the filter.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Look for chat filter handling code, likely in a class managing filter configuration and regex validation. The issue mentions logs with regex errors; start by finding where filters are loaded and validated on game launch. Test by creating a malformed regex filter and observing the log output to locate the validation point. The fix involves adding pre-save regex validation and user-facing error messages.

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
desktop
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。