5zig-reborn / 5zig-reborn/The-5zig-Mod

All Chat Filters Break if a Regex Filter cannot be Read

オープン
#94 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
Suggestion
主要言語
Java
スター
111
フォーク
12
PR マージ指標
30日以内にマージされた PR はありません

説明

Submitter: Yoshi
If a chat filter configured to be regex has some sort of problem and cannot be read (e.g. unmatched group parentheses), all other chat filters break completely upon relaunching the game.
This would not be a problem if one were told that the regex filter has some sort of regex problem before creation. However, no indication that something is wrong is visually said.
The only way to know is to look in the minecraft log as the incorrect regex string is created. In the log, this is shown: https://pastebin.com/dUYUu5ty
Upon relaunching the game and having a message be sent in chat, this 5zig/WARN is shown, and no chat filtering is applied at all: https://pastebin.com/jWtDRm6r

Therefore, the simplest solution to this problem is to not allow a regex chat filter be saved/created if there is a regex problem. Additionally, it would be helpful to specify the problem upon attempting to create the filter.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

Look for chat filter handling code, likely in a class managing filter configuration and regex validation. The issue mentions logs with regex errors; start by finding where filters are loaded and validated on game launch. Test by creating a malformed regex filter and observing the log output to locate the validation point. The fix involves adding pre-save regex validation and user-facing error messages.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
java
領域
desktop
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
停滞
明瞭さ
明確に書かれている
初心者へのやさしさ
55/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。