4paradigm / 4paradigm/OpenMLDB
SQLBatchRequestResultSet needs design optimization
- Langage dominant
- C++
- Étoiles
- 1.7k
- Forks
- 331
- Merge moyen
- 12 j 12 h
- PR mergées (30 j)
- 1
Description
- why SQLBatchRequestResultSet needs a brpc:Controller?
- SQLBatchRequestResultSet can get common view & non common view directly. We don't need to get all cols, then check if constant, push to common or non common data resp. It's meaningless decode and encode.
- SQLBatchRequestResultSet::GetSchema doesn't have the propery of constance. But we can't get common idx from SQLBatchRequestResultSet.
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Examine SQLBatchRequestResultSet class in the codebase to understand its current design and usage of brpc::Controller. Identify where common and non-common views are handled and how schema retrieval works. Look for existing tests related to result sets to understand expected behavior after optimization.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- cpp
- Domaine
- databases
- Type d'issue
- Refactorisation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100