4paradigm / 4paradigm/OpenMLDB

SQLBatchRequestResultSet needs design optimization

Offen
#78 0 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
enhancement
Vorherrschende Sprache
C++
Sterne
1.7k
Forks
331
Ø Merge
12 T. 12 Std.
Gemergte PRs (30 T.)
1

Beschreibung

- why SQLBatchRequestResultSet needs a brpc:Controller?
- SQLBatchRequestResultSet can get common view & non common view directly. We don't need to get all cols, then check if constant, push to common or non common data resp. It's meaningless decode and encode.
- SQLBatchRequestResultSet::GetSchema doesn't have the propery of constance. But we can't get common idx from SQLBatchRequestResultSet.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Examine SQLBatchRequestResultSet class in the codebase to understand its current design and usage of brpc::Controller. Identify where common and non-common views are handled and how schema retrieval works. Look for existing tests related to result sets to understand expected behavior after optimization.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
cpp
Bereich
databases
Issue-Typ
Refactoring
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Muss geklärt werden
Anfängerfreundlichkeit
25/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.