4paradigm / 4paradigm/OpenMLDB
CREATE FUNCTION: dlopen/dlclose not need to mutex lock handler
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 331
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 1
Description
`dlopen` returns handler that has reference count internally, we do not need to lock with the `map handler>`, the same for `dlclose`. A simple `map handler>` is cleaner.
Contributor guide
Research direction
Look for the CREATE FUNCTION implementation and the map handling dlopen/dlclose handlers. The issue suggests removing mutex locks around the filename-to-handler map and using a simpler fnname-to-handler map. Start by finding the relevant code in the source tree, likely around function loading or dynamic library management. Understand the current locking mechanism and reference counting to ensure thread safety without the mutex. Verify changes by building and testing the function loading functionality.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100