4paradigm / 4paradigm/OpenMLDB
CREATE FUNCTION: dlopen/dlclose not need to mutex lock handler
- Vorherrschende Sprache
- C++
- Sterne
- 1.7k
- Forks
- 331
- Ø Merge
- 12 T. 12 Std.
- Gemergte PRs (30 T.)
- 1
Beschreibung
`dlopen` returns handler that has reference count internally, we do not need to lock with the `map handler>`, the same for `dlclose`. A simple `map handler>` is cleaner.
Beitragsleitfaden
Rechercherichtung
Look for the CREATE FUNCTION implementation and the map handling dlopen/dlclose handlers. The issue suggests removing mutex locks around the filename-to-handler map and using a simpler fnname-to-handler map. Start by finding the relevant code in the source tree, likely around function loading or dynamic library management. Understand the current locking mechanism and reference counting to ensure thread safety without the mutex. Verify changes by building and testing the function loading functionality.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- cpp
- Bereich
- databases
- Issue-Typ
- Refactoring
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 45/100