4paradigm / 4paradigm/OpenMLDB
Refactor `SQLRequestRowBatch`
未关闭
call-for-contributions
sdk
- 主要语言
- C++
- 星标
- 1.7k
- 派生
- 331
- 平均合并
- 12 天 12 小时
- 30 天内合并 PR
- 1
描述
There are two sub-tasks:
- `SQLRequestRowBatch` copies string multiple times in the `AddRow` function. It's better to use `RefCountedSlice` rather than `String`.
- Extract a separate encode function from `RowSelector::Select`
贡献指南
调研方向
Look for the SQLRequestRowBatch class and its AddRow function to understand the string copying issue. Investigate RefCountedSlice usage elsewhere in the codebase. Also examine RowSelector::Select to identify the encode logic to extract. Start by building and running existing tests related to these components to ensure changes don't break functionality.
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- cpp
- 领域
- databases
- Issue 类型
- 重构
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100