4paradigm / 4paradigm/OpenMLDB
Refactor `SQLRequestRowBatch`
Ouverte
call-for-contributions
sdk
- Langage dominant
- C++
- Étoiles
- 1.7k
- Forks
- 331
- Merge moyen
- 12 j 12 h
- PR mergées (30 j)
- 1
Description
There are two sub-tasks:
- `SQLRequestRowBatch` copies string multiple times in the `AddRow` function. It's better to use `RefCountedSlice` rather than `String`.
- Extract a separate encode function from `RowSelector::Select`
Guide de contribution
Ouvrir le guide de contribution
Piste de recherche
Look for the SQLRequestRowBatch class and its AddRow function to understand the string copying issue. Investigate RefCountedSlice usage elsewhere in the codebase. Also examine RowSelector::Select to identify the encode logic to extract. Start by building and running existing tests related to these components to ensure changes don't break functionality.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- cpp
- Domaine
- databases
- Type d'issue
- Refactorisation
- Difficulté
- 3/5
- Temps estimé
- 1-2 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 45/100