4paradigm / 4paradigm/OpenMLDB

Refactor `SQLRequestRowBatch`

Open
#2,001 0 comments 0 reactions 0 assignees View on GitHub
call-for-contributions sdk
Dominant language
C++
Stars
1.7k
Forks
331
Avg merge
12d 12h
Merged PRs (30d)
1

Description

There are two sub-tasks:
- `SQLRequestRowBatch` copies string multiple times in the `AddRow` function. It's better to use `RefCountedSlice` rather than `String`.
- Extract a separate encode function from `RowSelector::Select`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.