4paradigm / 4paradigm/OpenMLDB

derived SqlNode/PlanNode/... may incomplete due to missing override for `Equals` method

未关闭
#1,285 0 条评论 0 个 reaction 已指派 1 人 已被 @aceforeverd 认领 在 GitHub 查看
enhancement
主要语言
C++
星标
1.7k
派生
331
平均合并
12 天 12 小时
30 天内合并 PR
1

描述

e.g
- DeployPlanNode: https://github.com/4paradigm/openmldb/blob/836b34119249ff9b667130b125c88395ef18ee4f/hybridse/include/node/plan_node.h#L477
- DeployNode: https://github.com/4paradigm/openmldb/blob/836b34119249ff9b667130b125c88395ef18ee4f/hybridse/include/node/sql_node.h#L2207

_Originally posted by @aceforeverd in https://github.com/4paradigm/OpenMLDB/pull/1283#discussion_r811867541_

贡献指南

打开贡献指南

调研方向

The issue points to two derived classes (DeployPlanNode and DeployNode) in hybridse/include/node/plan_node.h and sql_node.h that may be missing overrides for the `Equals` method. First, examine the base class hierarchy to understand the expected `Equals` signature and semantics. Then, check if other derived classes provide overrides as examples. Implement the missing overrides, ensuring they compare all relevant member variables. Run existing tests related to node equality to verify correctness.

由索引模型根据 Issue 内容生成。

评估

技术栈
cpp
领域
compilers
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。