4paradigm / 4paradigm/OpenMLDB
derived SqlNode/PlanNode/... may incomplete due to missing override for `Equals` method
- Dominant language
- C++
- Stars
- 1.7k
- Forks
- 331
- Avg merge
- 12d 12h
- Merged PRs (30d)
- 1
Description
e.g
- DeployPlanNode: https://github.com/4paradigm/openmldb/blob/836b34119249ff9b667130b125c88395ef18ee4f/hybridse/include/node/plan_node.h#L477
- DeployNode: https://github.com/4paradigm/openmldb/blob/836b34119249ff9b667130b125c88395ef18ee4f/hybridse/include/node/sql_node.h#L2207
_Originally posted by @aceforeverd in https://github.com/4paradigm/OpenMLDB/pull/1283#discussion_r811867541_
Contributor guide
Research direction
The issue points to two derived classes (DeployPlanNode and DeployNode) in hybridse/include/node/plan_node.h and sql_node.h that may be missing overrides for the `Equals` method. First, examine the base class hierarchy to understand the expected `Equals` signature and semantics. Then, check if other derived classes provide overrides as examples. Implement the missing overrides, ensuring they compare all relevant member variables. Run existing tests related to node equality to verify correctness.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100