0xSpaceShard / 0xSpaceShard/cairo-cli-docker

Build on side branches

Open
#15 0 comments 0 reactions 1 assignee Claimed by @Nathan-SL View on GitHub
Dominant language
Shell
Stars
10
Forks
4
PR merge metrics
No merged PRs in 30d

Description

Currently we only build on master, but for testing purposes, we could build on side branches, too. This is useful if we aren't just doing a simple cairo-lang update, but e.g. adding new commands.

It could be a simple build of just one image. Don't know how we would handle the environment variables (ARGs), ideally we wouldn't introduce duplication.

EDIT: the simplest approach would be to add a check in the shell script which checks the `CIRCLE_BRANCH` (an environment variable present in circleci) and only pushes the images if on `master`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Look at the existing CircleCI configuration and the shell script that builds Docker images. Identify where the build is triggered and where the CIRCLE_BRANCH environment variable can be used. Modify the script to conditionally push images only on the master branch, ensuring no duplication of ARGs. Test by creating a side branch and verifying the build runs without pushing.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, shell
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.