0xSpaceShard / 0xSpaceShard/cairo-cli-docker

Build on side branches

Offen
#15 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @Nathan-SL Auf GitHub ansehen
Vorherrschende Sprache
Shell
Sterne
10
Forks
4
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Currently we only build on master, but for testing purposes, we could build on side branches, too. This is useful if we aren't just doing a simple cairo-lang update, but e.g. adding new commands.

It could be a simple build of just one image. Don't know how we would handle the environment variables (ARGs), ideally we wouldn't introduce duplication.

EDIT: the simplest approach would be to add a check in the shell script which checks the `CIRCLE_BRANCH` (an environment variable present in circleci) and only pushes the images if on `master`.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Look at the existing CircleCI configuration and the shell script that builds Docker images. Identify where the build is triggered and where the CIRCLE_BRANCH environment variable can be used. Modify the script to conditionally push images only on the master branch, ensuring no duplication of ARGs. Test by creating a side branch and verifying the build runs without pushing.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
docker, shell
Bereich
build-system, ci-cd
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.