0xMiden / 0xMiden/wallet

Bridge-IN E2E: provision a dedicated WalletConnect projectId + re-enable gating

未關閉
#404 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
5
分支
28
平均合併
16 小時 40 分鐘
30 天內合併 PR
99

描述

**Bridge-IN E2E is currently non-blocking** (`continue-on-error` added in #402) because it fails on `WS close 3000 ("Project not found")` — the WalletConnect relay rejects the app's projectId (the shared free-tier fallback `b54ef53f…`, since no `WALLETCONNECT_PROJECT_ID` secret is set). It's a suspended/rate-limited projectId, not a code bug, and it has never passed on main. Bridge-in is currently hidden from users (`isBridgeDepositEnabled`).

### To restore blocking coverage
1. Provision a dedicated WalletConnect Cloud projectId (ideally two — one for the app, one for the headless counterparty, to halve per-projectId relay load).
2. Add them as CI secrets: `WALLETCONNECT_PROJECT_ID` and `WC_COUNTERPARTY_PROJECT_ID` (the workflow + `wc-counterparty.ts` already read these).
3. Remove the `continue-on-error: true` on the "Run bridge-IN deposit E2E" step in `.github/workflows/e2e-bridge-in.yml`.

The handshake-retry resilience (#401) is already in place for transient relay subscribe timeouts once the projectId is valid.

貢獻指南

開啟貢獻指南

研究方向

該 issue 引用了工作流程檔案 `.github/workflows/e2e-bridge-in.yml` 和對應方腳本 `wc-counterparty.ts`。首先檢查這些檔案以了解當前設定以及讀取 projectId 秘密的位置。您需要配置新的 WalletConnect Cloud 專案 ID,將它們新增為 GitHub 秘密,並更新工作流程以移除 `continue-on-error` 旗標。如果可能,請透過本地執行 E2E 測試來驗證變更。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
typescript
領域
ci-cd, devops, testing
Issue 類型
功能
難度
3/5
預估耗時
1-2 天
活躍度
冷清
描述清晰度
描述清楚
新手友好度
55/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。