0xMiden / 0xMiden/wallet

Bridge-IN E2E: provision a dedicated WalletConnect projectId + re-enable gating

Aperta
#404 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
5
Fork
28
Merge medio
9h 50m
PR unite (30g)
123

Descrizione

**Bridge-IN E2E is currently non-blocking** (`continue-on-error` added in #402) because it fails on `WS close 3000 ("Project not found")` — the WalletConnect relay rejects the app's projectId (the shared free-tier fallback `b54ef53f…`, since no `WALLETCONNECT_PROJECT_ID` secret is set). It's a suspended/rate-limited projectId, not a code bug, and it has never passed on main. Bridge-in is currently hidden from users (`isBridgeDepositEnabled`).

### To restore blocking coverage
1. Provision a dedicated WalletConnect Cloud projectId (ideally two — one for the app, one for the headless counterparty, to halve per-projectId relay load).
2. Add them as CI secrets: `WALLETCONNECT_PROJECT_ID` and `WC_COUNTERPARTY_PROJECT_ID` (the workflow + `wc-counterparty.ts` already read these).
3. Remove the `continue-on-error: true` on the "Run bridge-IN deposit E2E" step in `.github/workflows/e2e-bridge-in.yml`.

The handshake-retry resilience (#401) is already in place for transient relay subscribe timeouts once the projectId is valid.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.