0xMiden / 0xMiden/rust-sdk

Better display implementations for `NoteTag`

未關閉
#1,436 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
cli
主要語言
Rust
星號
78
分支
129
平均合併
4 天 14 小時
30 天內合併 PR
52

描述

(This issue might be better suited for `miden-base`)

On the CLI occasionally we have to display note tags, and we don't take any special approach other than just displaying the number. Tags are quite arbitrary so this is not incorrect, but there are better things we could do. For example, for note tags that represent account prefixes, I wonder if we could show them as the first few account ID numbers as hexadecimal (so as to easily compare to a hex representation of `AccountId`).

Because we have some information about the tag (whether it was user-added, or if it's related to an account, etc.), we could fairly easily improve this. But also, tags have an associated meaning (not enforced), so maybe this can be tackled at the `NoteTag` level instead of the `NoteTagRecord` one.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。