0xMiden / 0xMiden/rust-sdk

Better display implementations for `NoteTag`

未关闭
#1,436 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
cli
主要语言
Rust
星标
78
派生
129
平均合并
4 天 14 小时
30 天内合并 PR
52

描述

(This issue might be better suited for `miden-base`)

On the CLI occasionally we have to display note tags, and we don't take any special approach other than just displaying the number. Tags are quite arbitrary so this is not incorrect, but there are better things we could do. For example, for note tags that represent account prefixes, I wonder if we could show them as the first few account ID numbers as hexadecimal (so as to easily compare to a hex representation of `AccountId`).

Because we have some information about the tag (whether it was user-added, or if it's related to an account, etc.), we could fairly easily improve this. But also, tags have an associated meaning (not enforced), so maybe this can be tackled at the `NoteTag` level instead of the `NoteTagRecord` one.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。