0xMiden / 0xMiden/rust-sdk

Better display implementations for `NoteTag`

Aperta
#1,436 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
cli
Lingua principale
Rust
Stelle
78
Fork
129
Merge medio
4g 14h
PR unite (30g)
52

Descrizione

(This issue might be better suited for `miden-base`)

On the CLI occasionally we have to display note tags, and we don't take any special approach other than just displaying the number. Tags are quite arbitrary so this is not incorrect, but there are better things we could do. For example, for note tags that represent account prefixes, I wonder if we could show them as the first few account ID numbers as hexadecimal (so as to easily compare to a hex representation of `AccountId`).

Because we have some information about the tag (whether it was user-added, or if it's related to an account, etc.), we could fairly easily improve this. But also, tags have an associated meaning (not enforced), so maybe this can be tackled at the `NoteTag` level instead of the `NoteTagRecord` one.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.