0xMiden / 0xMiden/protocol

Test all kernel and library procedures with additional stack elements

オープン
#675 コメント 1 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
Rust
スター
132
フォーク
167
平均マージ
1日 23時間
マージ済み PR(30日)
110

説明

### What should be done?

Ensuring the procedures in the stdlib and the kernel ABI is correct is a requirement to build programs on top of it. Some of our procedures are not properly handling the stack, either they consume additional elements from the stack or leave elements in the stack, and this is not caught by the tests because the VM automatically fills the top of the stack with zeros.

To caught issues like the ones mentioned above, our tests should add random elements to the stack before calling any procedure, and asserting said elements are still available in the stack after the procedure call.

### How should it be done?

Change existing tests to:

- Initialize the stack with more elements than required prior to a procedure call
- Assert the elements mentioned above are untouched after calling the above procedure

### When is this task done?

When the existing tests have been updated

### Additional context

_No response_

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。