0xMiden / 0xMiden/protocol

Test all kernel and library procedures with additional stack elements

Aperta
#675 1 commento 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

### What should be done?

Ensuring the procedures in the stdlib and the kernel ABI is correct is a requirement to build programs on top of it. Some of our procedures are not properly handling the stack, either they consume additional elements from the stack or leave elements in the stack, and this is not caught by the tests because the VM automatically fills the top of the stack with zeros.

To caught issues like the ones mentioned above, our tests should add random elements to the stack before calling any procedure, and asserting said elements are still available in the stack after the procedure call.

### How should it be done?

Change existing tests to:

- Initialize the stack with more elements than required prior to a procedure call
- Assert the elements mentioned above are untouched after calling the above procedure

### When is this task done?

When the existing tests have been updated

### Additional context

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.