Domain separation for protocol object commitments
- 主要语言
- Rust
- 星标
- 132
- 派生
- 167
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 110
描述
Various recent PRs (e.g., https://github.com/0xMiden/protocol/pull/3662, https://github.com/0xMiden/protocol/pull/3670) added versioning to various protocol objects. But as discussed in https://github.com/0xMiden/protocol/issues/1155, it would be beneficial to add domain separation to these schemes as well. We also have an RFC in https://github.com/0xMiden/crypto/pull/1026 that proposes a uniform approach to both versioning and domain separation.
To complete this issue we need to:
- Align on the versioning approach. My current thinking here is versioning could remain as it currently is (i.e., part of the payload that is being hashed).
- Implement a uniform scheme for domain separation (e.g., building on `SequentialCommit` or a `Hasher` trait).
- Apply this scheme to protocol objects - probably the same ones as we've implemented versioning for - though, maybe the set should be expanded.
贡献指南
评估
这个 Issue 还没有评估数据。