0xMiden / 0xMiden/protocol

Domain separation for protocol object commitments

Đang mở
#3,770 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
kernels rust
Ngôn ngữ chính
Rust
Star
132
Fork
167
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
110

Mô tả

Various recent PRs (e.g., https://github.com/0xMiden/protocol/pull/3662, https://github.com/0xMiden/protocol/pull/3670) added versioning to various protocol objects. But as discussed in https://github.com/0xMiden/protocol/issues/1155, it would be beneficial to add domain separation to these schemes as well. We also have an RFC in https://github.com/0xMiden/crypto/pull/1026 that proposes a uniform approach to both versioning and domain separation.

To complete this issue we need to:

- Align on the versioning approach. My current thinking here is versioning could remain as it currently is (i.e., part of the payload that is being hashed).
- Implement a uniform scheme for domain separation (e.g., building on `SequentialCommit` or a `Hasher` trait).
- Apply this scheme to protocol objects - probably the same ones as we've implemented versioning for - though, maybe the set should be expanded.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.