0xMiden / 0xMiden/protocol

Change the signature of auth scripts to accept `FEE_ARGS` in addition to `AUTH_ARGS`

未關閉
#3,316 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
fees kernels
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

I think a cleaner approach would be to change the signature to accept "fee args" as a second word - i.g.:

```
pub type FeeArgs = struct { faucet_id: AccountId, rate: ConversionRate }
pub type ConversionRate = struct { lo: felt, hi: felt }

#! Inputs: [AUTH_ARGS, FEE_ARGS, pad(8)]
#! Outputs: [pad(16)]
#!
#! Invocation: call
@auth_script
pub proc auth_tx(auth_args: word, fee_args: FeeArgs)
...
end
```

This is a bit more work though - so, probably best to do in a follow-up.

_Originally posted by @bobbinth in https://github.com/0xMiden/protocol/pull/3298#discussion_r3583044185_

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。