0xMiden / 0xMiden/protocol

Change the signature of auth scripts to accept `FEE_ARGS` in addition to `AUTH_ARGS`

Ouverte
#3,316 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
fees kernels
Langage dominant
Rust
Étoiles
132
Forks
167
Merge moyen
1 j 23 h
PR mergées (30 j)
110

Description

I think a cleaner approach would be to change the signature to accept "fee args" as a second word - i.g.:

```
pub type FeeArgs = struct { faucet_id: AccountId, rate: ConversionRate }
pub type ConversionRate = struct { lo: felt, hi: felt }

#! Inputs: [AUTH_ARGS, FEE_ARGS, pad(8)]
#! Outputs: [pad(16)]
#!
#! Invocation: call
@auth_script
pub proc auth_tx(auth_args: word, fee_args: FeeArgs)
...
end
```

This is a bit more work though - so, probably best to do in a follow-up.

_Originally posted by @bobbinth in https://github.com/0xMiden/protocol/pull/3298#discussion_r3583044185_

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.