0xMiden / 0xMiden/protocol

Simplify or remove CodeBuilder after the package migration

未关闭
#3,193 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Rust
星标
132
派生
167
平均合并
1 天 23 小时
30 天内合并 PR
110

描述

#3146 kept `CodeBuilder` working with packages, but the module now has adapter traits that mostly forward to package based assembly.

Motivating PR comment:

- https://github.com/0xMiden/protocol/pull/3146#discussion_r3516297135

The main path is [`crates/miden-standards/src/code_builder/mod.rs`](https://github.com/0xMiden/protocol/blob/2432a082e53c7e16b2885c8ee42e05489480358c/crates/miden-standards/src/code_builder/mod.rs#L33-L120). The package migration version is on #3146, so this permalink points at the PR head.

Please decide whether `CodeBuilder` should stay as a public helper.

If it stays, make it smaller:

- accept package values directly where possible.
- avoid broad adapter traits unless a caller needs them.
- keep note script source parsing close to the one call site.

If it no longer earns its place, remove it and update tests to use the package assembly APIs directly.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。