0xMiden / 0xMiden/protocol

Simplify or remove CodeBuilder after the package migration

Abierto
#3,193 6 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

#3146 kept `CodeBuilder` working with packages, but the module now has adapter traits that mostly forward to package based assembly.

Motivating PR comment:

- https://github.com/0xMiden/protocol/pull/3146#discussion_r3516297135

The main path is [`crates/miden-standards/src/code_builder/mod.rs`](https://github.com/0xMiden/protocol/blob/2432a082e53c7e16b2885c8ee42e05489480358c/crates/miden-standards/src/code_builder/mod.rs#L33-L120). The package migration version is on #3146, so this permalink points at the PR head.

Please decide whether `CodeBuilder` should stay as a public helper.

If it stays, make it smaller:

- accept package values directly where possible.
- avoid broad adapter traits unless a caller needs them.
- keep note script source parsing close to the one call site.

If it no longer earns its place, remove it and update tests to use the package assembly APIs directly.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.