0xMiden / 0xMiden/protocol

Optimize input note num inputs/assets memory layout

未关闭
#2,256 2 条评论 0 个 reaction 已指派 1 人 已被 @hawkadrian 认领 在 GitHub 查看
good first issue kernels
主要语言
Rust
星标
132
派生
167
平均合并
1 天 23 小时
30 天内合并 PR
110

描述

After #2109 is closed (to avoid merge conflicts), we should be able to make a tiny PR that moves these two constants closer together:

https://github.com/0xMiden/miden-base/blob/eee0e8450b825857e7d56ffebfaa269378a61aca/crates/miden-protocol/src/transaction/kernel/memory.rs#L388-L389

It should be possible to do:
```rust
pub const INPUT_NOTE_NUM_INPUTS_OFFSET: MemoryOffset = 36;
pub const INPUT_NOTE_NUM_ASSETS_OFFSET: MemoryOffset = 37;
pub const INPUT_NOTE_ASSETS_OFFSET: MemoryOffset = 40
```

This applies to `memory.masm` in the same way.

Context: https://github.com/0xMiden/miden-base/pull/2249#discussion_r2679280006

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。