Optimize input note num inputs/assets memory layout
Offen
#2,256
2 Kommentare
0 Reaktionen
1 zugewiesene Person
Beansprucht von @hawkadrian
Auf GitHub ansehen
good first issue
kernels
- Vorherrschende Sprache
- Rust
- Sterne
- 132
- Forks
- 167
- Ø Merge
- 1 T. 23 Std.
- Gemergte PRs (30 T.)
- 110
Beschreibung
After #2109 is closed (to avoid merge conflicts), we should be able to make a tiny PR that moves these two constants closer together:
https://github.com/0xMiden/miden-base/blob/eee0e8450b825857e7d56ffebfaa269378a61aca/crates/miden-protocol/src/transaction/kernel/memory.rs#L388-L389
It should be possible to do:
```rust
pub const INPUT_NOTE_NUM_INPUTS_OFFSET: MemoryOffset = 36;
pub const INPUT_NOTE_NUM_ASSETS_OFFSET: MemoryOffset = 37;
pub const INPUT_NOTE_ASSETS_OFFSET: MemoryOffset = 40
```
This applies to `memory.masm` in the same way.
Context: https://github.com/0xMiden/miden-base/pull/2249#discussion_r2679280006
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.