0xMiden / 0xMiden/protocol

Optimize input note num inputs/assets memory layout

Abierto
#2,256 2 comentarios 0 reacciones 1 asignado Reclamado por @hawkadrian Ver en GitHub
good first issue kernels
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

After #2109 is closed (to avoid merge conflicts), we should be able to make a tiny PR that moves these two constants closer together:

https://github.com/0xMiden/miden-base/blob/eee0e8450b825857e7d56ffebfaa269378a61aca/crates/miden-protocol/src/transaction/kernel/memory.rs#L388-L389

It should be possible to do:
```rust
pub const INPUT_NOTE_NUM_INPUTS_OFFSET: MemoryOffset = 36;
pub const INPUT_NOTE_NUM_ASSETS_OFFSET: MemoryOffset = 37;
pub const INPUT_NOTE_ASSETS_OFFSET: MemoryOffset = 40
```

This applies to `memory.masm` in the same way.

Context: https://github.com/0xMiden/miden-base/pull/2249#discussion_r2679280006

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.