0xMiden / 0xMiden/protocol

Rename `seed` to `id_salt` to avoid confusion with wallet **seed** phrases

未关闭
#1,992 5 条评论 2 个 reaction 已指派 1 人 已被 @Peponks9 认领 在 GitHub 查看
主要语言
Rust
星标
132
派生
167
平均合并
1 天 23 小时
30 天内合并 PR
110

描述

The term `seed` in Miden refers to a value used during account ID generation. This is fundamentally different from how "seed" is used in Ethereum/Bitcoin, where it refers to BIP39 mnemonic phrases for hierarchical key derivation and wallet recovery.

This terminology overlap is confusing for developers coming from the Ethereum ecosystem.

I (re-)realized this when reviewing https://github.com/0xMiden/miden-base/pull/1805/, and there the `AccountDataExport` actually includes "seed", which is counterintuitive.

### Proposal

Rename `seed` -> `account_salt`

Alternatives:
- `id_salt` - shorter but less explicit, might also be confusing
- `account_id_salt` (my second favorite)
- `account_genesis_salt` - emphasizes one-time use, but maybe too verbose?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。