0xMiden / 0xMiden/protocol

Rename `seed` to `id_salt` to avoid confusion with wallet **seed** phrases

Ouverte
#1,992 5 commentaires 2 réactions 1 personne assignée Réclamée par @Peponks9 Voir sur GitHub
Langage dominant
Rust
Étoiles
132
Forks
167
Merge moyen
1 j 23 h
PR mergées (30 j)
110

Description

The term `seed` in Miden refers to a value used during account ID generation. This is fundamentally different from how "seed" is used in Ethereum/Bitcoin, where it refers to BIP39 mnemonic phrases for hierarchical key derivation and wallet recovery.

This terminology overlap is confusing for developers coming from the Ethereum ecosystem.

I (re-)realized this when reviewing https://github.com/0xMiden/miden-base/pull/1805/, and there the `AccountDataExport` actually includes "seed", which is counterintuitive.

### Proposal

Rename `seed` -> `account_salt`

Alternatives:
- `id_salt` - shorter but less explicit, might also be confusing
- `account_id_salt` (my second favorite)
- `account_genesis_salt` - emphasizes one-time use, but maybe too verbose?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.